Adding RT-1.36: AIGP feature support test by ASHNA-AGGARWAL-KEYSIGHT · Pull Request #5375 · openconfig/featureprofiles

ASHNA-AGGARWAL-KEYSIGHT · 2026-04-23T20:48:58Z

Readme: https://github.com/toadeniy-g/featureprofiles/blob/main/feature/bgp/otg_tests/aigp_test/README.md

Raised an issue for the test not passing completely: https://partnerissuetracker.corp.google.com/issues/505782544

OpenConfigBot · 2026-04-23T20:49:29Z

Pull Request Functional Test Report for #5375 / `3c7ca13`

Virtual Devices

Device	Test	Test Documentation	Job	Raw Log
Arista cEOS		RT-1.36: AIGP feature support test
Cisco 8000E		RT-1.36: AIGP feature support test
Cisco XRd		RT-1.36: AIGP feature support test
Juniper ncPTX		RT-1.36: AIGP feature support test
Nokia SR Linux		RT-1.36: AIGP feature support test
Openconfig Lemming		RT-1.36: AIGP feature support test

Hardware Devices

Device	Test	Test Documentation	Raw Log
Arista 7808		RT-1.36: AIGP feature support test
Cisco 8808		RT-1.36: AIGP feature support test
Juniper PTX10008		RT-1.36: AIGP feature support test
Nokia 7250 IXR-10e		RT-1.36: AIGP feature support test

Help

gemini-code-assist · 2026-04-23T20:50:06Z

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces comprehensive test coverage for the BGP AIGP (Accumulated IGP Metric) feature, ensuring correct attribute propagation and policy application across different network instances. Additionally, it refactors and extends internal test infrastructure to support new configuration requirements and device-specific deviations, while also refining existing ISIS graceful restart tests for better reliability.

Highlights

New AIGP Feature Test: Added a new test suite for AIGP feature support (RT-1.36) including validation for attribute modification, propagation, and tie-breaking.
Infrastructure Updates: Updated internal configuration plugins to support VLAN client encapsulation, improved BGP peer verification for VRFs, and added new device deviations for AIGP and RIB support.
ISIS Graceful Restart Improvements: Enhanced ISIS graceful restart test coverage with new telemetry verification methods and improved state handling.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

This pull request introduces a new test suite for the BGP Accumulated IGP Metric (AIGP) feature and updates ISIS Graceful Restart tests with improved telemetry checks. It also extends internal configuration plugins and deviations to support Arista-specific CLI fallbacks for BGP policies, interface encapsulation, and sub-interface formatting. The review feedback identifies a misleading error message in the RIB validation logic, a bug in a test case log format that repeats the test name instead of the description, and the presence of leftover debug logs that should be removed.

gemini-code-assist · 2026-04-23T20:52:32Z

+	gotAIGP := attrSet.GetAigp()
+	if gotAIGP != wantAIGP {
+		t.Errorf("fail: aigp for neighbor %s in NI %s: want %d, got %d", nbrAddr, ni, wantAIGP, gotAIGP)
+		t.Errorf("OC not supported for AIGP attribute in BGP RIB")


This error message is misleading. Since gotAIGP was successfully retrieved using OpenConfig on line 1023, the claim that OpenConfig is not supported is contradictory. If the metric comparison fails, the preceding t.Errorf on line 1026 already provides the necessary failure details. Additionally, consider using t.Fatalf instead of t.Errorf if a failure here makes subsequent test steps meaningless.

References

In tests, t.Fatalf is preferred over t.Errorf when a failure makes subsequent test steps meaningless, as this fails fast and reduces overall test execution time.

gemini-code-assist · 2026-04-23T20:52:32Z

+	// Run the test cases.
+	for _, tc := range testCases {
+		t.Run(tc.name, func(t *testing.T) {
+			t.Logf("Description: %s - %s", tc.name, tc.name)


The log message incorrectly repeats tc.name. It should use tc.description for the second format specifier to provide the intended test case description.

Suggested change

t.Logf("Description: %s - %s", tc.name, tc.name)

t.Logf("Description: %s - %s", tc.name, tc.description)

gemini-code-assist · 2026-04-23T20:52:32Z

+	t.Log(dut1loopback10.loopbackIntfName)
+	t.Log(dut2loopback10.loopbackIntfName)


These t.Log statements appear to be leftover debug logs and should be removed from the production test code.

nandanarista · 2026-05-02T00:30:48Z

 	gnmi.Update(t, dut, gnmi.OC().Config(), d)
 }
+
+// VlanClientEncapsulationParams configures vlan encapsulation params


i don't have a suggestion of where to move the diff in this file, but none of the additions are mpls related, so doesn't belong in this file.

nandanarista · 2026-05-02T00:31:20Z

+
+func VlanClientEncapsulation(t *testing.T, batch *gnmi.SetBatch, dut *ondatra.DUTDevice, params VlanClientEncapsulationParams) {
+	if deviations.VlanClientEncapsulationOcUnsupported(dut) {
+		cli := ""


cli needs to be conditional on a dut.vendor() check, right?

nandanarista · 2026-05-02T00:31:44Z

+		}
+		helpers.GnmiCLIConfig(t, dut, cli)
+	} else {
+		// OC is not available


what does this mean? are oc paths not defined?

nandanarista · 2026-05-02T00:32:26Z

+}
+
+func VlanClientEncapsulation(t *testing.T, batch *gnmi.SetBatch, dut *ondatra.DUTDevice, params VlanClientEncapsulationParams) {
+	if deviations.VlanClientEncapsulationOcUnsupported(dut) {


not sure this needs to be a devition as this is used to workaround testbed contraints. it's not functionality germane to the test.

nandanarista · 2026-05-02T00:36:34Z

 }

+// VerifyDUTBGPEstablishedForVRF verifies on DUT BGP peer establishment
+func VerifyDUTBGPEstablishedForVRF(t *testing.T, dut *ondatra.DUTDevice, ni string, duration ...time.Duration) {


this is identincal to VerifyDUTBGPEstablished expect for the vrf name, please refactor

nandanarista · 2026-05-02T00:46:43Z

+		if enable {
+			cliConfig += fmt.Sprintf(`
+								  neighbor %s aigp-session
+								`, nbrIp)
+		} else {
+			cliConfig += fmt.Sprintf(`
+								  no neighbor %s aigp-session
+								`, nbrIp)
+		}


if !enable {
maybeNo = "no "
}
cliConfig += fmt.Sprintf(%sneighbor %s aigp-session, maybeNo, nbrIp)

nandanarista · 2026-05-02T00:49:18Z

+	if deviations.AIGPRouteMetricNotSupported(dut) {
+		switch dut.Vendor() {
+		case ondatra.ARISTA:
+			cliConfig := fmt.Sprintf(`route-map %s statement %s `, params.PolicyName, params.StatementName)


we should be using RCF

ASHNA-AGGARWAL-KEYSIGHT requested review from a team as code owners April 23, 2026 20:49

gemini-code-assist Bot reviewed Apr 23, 2026

View reviewed changes

Adding RT-1.36: AIGP feature support test

3c7ca13

ASHNA-AGGARWAL-KEYSIGHT force-pushed the fpt_otg_RT_1_36 branch from bdf443e to 3c7ca13 Compare April 23, 2026 21:05

ksgireesha requested review from ram-mac, rohit-rp and toadeniy-g April 24, 2026 04:13

nandanarista suggested changes May 2, 2026

View reviewed changes

	t.Logf("Description: %s - %s", tc.name, tc.name)
	t.Logf("Description: %s - %s", tc.name, tc.description)

		t.Log(dut1loopback10.loopbackIntfName)
		t.Log(dut2loopback10.loopbackIntfName)

Conversation

ASHNA-AGGARWAL-KEYSIGHT commented Apr 23, 2026

Uh oh!

OpenConfigBot commented Apr 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pull Request Functional Test Report for #5375 / 3c7ca13

Virtual Devices

Hardware Devices

Uh oh!

gemini-code-assist Bot commented Apr 23, 2026

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist Bot Apr 23, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot Apr 23, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot Apr 23, 2026

Choose a reason for hiding this comment

Uh oh!

nandanarista May 2, 2026

Choose a reason for hiding this comment

Uh oh!

nandanarista May 2, 2026

Choose a reason for hiding this comment

Uh oh!

nandanarista May 2, 2026

Choose a reason for hiding this comment

Uh oh!

nandanarista May 2, 2026

Choose a reason for hiding this comment

Uh oh!

nandanarista May 2, 2026

Choose a reason for hiding this comment

Uh oh!

nandanarista May 2, 2026

Choose a reason for hiding this comment

Uh oh!

nandanarista May 2, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

OpenConfigBot commented Apr 23, 2026 •

edited

Loading

Pull Request Functional Test Report for #5375 / `3c7ca13`